Skip to content

Migrate merge imports to editor#22351

Open
Shourya742 wants to merge 8 commits into
rust-lang:masterfrom
Shourya742:2026-05-10-migrate-merge-imports-to-editor
Open

Migrate merge imports to editor#22351
Shourya742 wants to merge 8 commits into
rust-lang:masterfrom
Shourya742:2026-05-10-migrate-merge-imports-to-editor

Conversation

@Shourya742

Copy link
Copy Markdown
Member

part of #15710 and #18285

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2026
@Shourya742 Shourya742 force-pushed the 2026-05-10-migrate-merge-imports-to-editor branch 4 times, most recently from d144bca to 935f981 Compare May 13, 2026 04:34

@ChayimFriedman2 ChayimFriedman2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed all of the code yet, only most of it.

View changes since this review

Comment thread crates/syntax/src/ast/edit.rs Outdated
Comment thread crates/ide-assists/src/handlers/merge_imports.rs Outdated
Comment thread crates/ide-assists/src/handlers/merge_imports.rs Outdated
Comment thread crates/ide-db/src/imports/merge_imports.rs Outdated
Comment thread crates/ide-db/src/imports/merge_imports.rs Outdated
@Shourya742 Shourya742 force-pushed the 2026-05-10-migrate-merge-imports-to-editor branch from 935f981 to d1fc4ad Compare May 25, 2026 17:34
@Shourya742 Shourya742 force-pushed the 2026-05-10-migrate-merge-imports-to-editor branch from d1fc4ad to f5e3520 Compare May 26, 2026 06:09
@Shourya742 Shourya742 force-pushed the 2026-05-10-migrate-merge-imports-to-editor branch from f5e3520 to d800e4d Compare June 3, 2026 02:55
@rustbot

This comment has been minimized.

@Shourya742 Shourya742 mentioned this pull request Jun 3, 2026
@rustbot

This comment has been minimized.

@Shourya742 Shourya742 force-pushed the 2026-05-10-migrate-merge-imports-to-editor branch from d800e4d to 0015ecd Compare June 12, 2026 09:36
@rustbot

rustbot commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants